Skip to content

Factory 0.4.7

Choose a tag to compare

@lpbaril lpbaril released this 13 Nov 14:28
· 6 commits to master since this release

Factory 0.4.7 lets a Planner mark its READY plan ready again when no design review round has read it, so the plan gets its round without a duplicate comment. It also says plainly why a plan has no round.

After 0.4.6, a plan stuck by the old round cap could only get its review by being posted again, word for word, as a new comment: bb factory plan-ready refused the comment that was already the READY plan. The same happened when a round's reviewers couldn't start. The Lead was told to have the Planner "mark it ready again", which was impossible.

What changes

  • Marking the same plan again starts its round. This works when no round has read the plan and you haven't accepted it, for example when its reviewers couldn't start. A review still at the round cap starts no round, whatever is marked.
  • Your answers are kept. Marking the same plan again keeps your answers to its questions, and the Lead isn't asked again. If you answered a question differently, the Planner still owes a new plan, and marking the old one again is refused.
  • Clearer refusals. A plan a round has read is refused with "design review has read it". A plan you accepted is refused with "the person accepted it as it is".
  • The Lead hears about a failed start once per plan. If the reviewers' provider is down, marking the plan again while it's still down tells the Planner the Lead already knows. A new plan is a new attempt.
  • The Builder gate says why a plan has no round: "its design reviewers couldn't start" or "no design review round has read it", with the exact plan-ready command that starts one, or design-accept.

When you upgrade

  • Nothing to do. A plan marked ready with no round under an earlier version can be marked again as it is.

Limits

  • Not tried for real yet: no plan has been marked again on this version. The plan that prompted this was reposted as a new comment, and has since passed its review.

Full Changelog: v0.4.6...v0.4.7