Skip to content

v0.4.0

  • v0.4.0
  • f311d07
  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
  • Choose a tag to compare

  • v0.4.0
  • f311d07
  • Choose a tag to compare

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lsegal lsegal tagged this 07 Oct 16:31
The `v0.4.0` Release run
([37651969262](https://github.com/lsegal/zvidlib/actions/runs/37651969262))
failed in **Publish the crates to crates.io**. This was the first real
run of that step (#610). The run stopped before uploading anything, so
no crate is on crates.io and no GitHub release was created.

## Root cause

**Build release assets** copies the crate archives and the `zvidlib-web`
tgz into `release/` inside the checkout. `cargo publish --workspace`
then refused to package the root `zvidlib` crate: "22 files in the
working directory contain changes that were not yet committed into git",
namely every file in `release/`. The wasm-pack `pkg/` directory has its
own catch-all `.gitignore`, so it never caused the problem.

## Change

Add `/release/` to `.gitignore`, so the release assets no longer leave
the tree dirty. The workflow itself is unchanged, and so is the publish
step's dirty-tree check, which still guards against publishing local
edits.

## Tests

- Reproduced locally: with a file under `release/`, `cargo package -p
zvidlib --no-verify` fails with the same uncommitted-changes error. With
this change, the dirty check passes, and `cargo package --workspace
--exclude zvidlib-bench-support --no-verify` packages every crate with
`release/` populated.

No changelog entry: this makes the 0.4.0 entry for crates.io publishing
(#610) true for the 0.4.0 release itself. After merge, I'll move the
unconsumed `v0.4.0` tag to the merge commit so the Release workflow runs
with this fix.

Addresses #632

**Agents:** claude-code (claude-opus-5-5)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Assets 2
Loading