Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.teresaignore doesn't works like .gitignore #451

Closed
jairhenrique opened this issue Mar 15, 2018 · 3 comments
Closed

.teresaignore doesn't works like .gitignore #451

jairhenrique opened this issue Mar 15, 2018 · 3 comments
Assignees

Comments

@jairhenrique
Copy link
Contributor

Scenario

# .gitignore
composer.phar
vendor/
# .teresaignore
composer.phar
vendor/

When I run git status the folder vendor/ are not listed on my shell output, but when I do a deploy on Teresa, I see this message:

!     WARNING: Your Composer vendor dir is part of your Git repository.
       This directory should not be under version control; only your
       'composer.json' and 'composer.lock' files should be added, which
       will let Composer handle installation of dependencies on deploy.
       To suppress this notice, first remove the folder from your index
       by running 'git rm -r --cached vendor/'.
       Next, edit your project's '.gitignore' file and add the folder
       '/vendor/' to the list.
       For more info, refer to the Composer FAQ: http://bit.ly/1rlCSZU

So, Teresa are including the folder vendor on tarball for deploy.


Changing .teresaignore to this:

composer.phar
vendor

vendor folder are not include and the buildpack install my dependencies.

@drgarcia1986
Copy link
Contributor

Thank you @jairhenrique, I'll check 👍

@drgarcia1986 drgarcia1986 self-assigned this Mar 20, 2018
@drgarcia1986
Copy link
Contributor

drgarcia1986 commented Mar 20, 2018

Again @jairhenrique, thank you for the report.

.teresaignore doesn't works like .gitignore, .teresaignore uses the glob pattern (.gitignore also uses, but is more intelligent LOL), but I saw that Teresa checks directories in the same way of a regular file (i.e. without a slash on end), I can add a slash in end of each directory name before check the pattern, will that change help you?

@drgarcia1986
Copy link
Contributor

drgarcia1986 commented Mar 20, 2018

Ok, there are more problems with .teresaignore, f.ex, ignore a file inside a directory.
I'm looking for a solution for theses problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants