This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Update xml-instructions.md #2005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved the formatting of the block class required message.
jeff-matthews
suggested changes
May 30, 2018
| @@ -48,7 +48,7 @@ Defines a block. | |||
| Blocks employ templates to generate {% glossarytooltip a2aff425-07dd-4bd6-9671-29b7edefa871 %}HTML{% endglossarytooltip %}. Examples of blocks include a {% glossarytooltip 50e49338-1e6c-4473-8527-9e401d67ea2b %}category{% endglossarytooltip %} list, a mini cart, product tags, and product listing.</p> | |||
|
|
|||
| <div class="bs-callout bs-callout-info"> | |||
There was a problem hiding this comment.
Add the markdown="1" attribute to use markdown syntax:
<div class="bs-callout bs-callout-info" markdown="1">
jeff-matthews
added
the
Editorial
Update note to use markdown
|
Nice, I've changed it back and added |
jeff-matthews
suggested changes
May 30, 2018
| <div class="bs-callout bs-callout-info"> | ||
| <p>The class attribute is no longer required in version <code>2.2.1</code> and above as it will default to <code>Magento\Framework\View\Element\Template</code>. <b>In versions lower than `2.2.1` class is still required.</b></p> | ||
| <div class="bs-callout bs-callout-info" markdown="1"> | ||
| <p>The class attribute is no longer required in version `2.2.1` and above as it will default to `Magento\Framework\View\Element\Template`. **In versions lower than `2.2.1` class is still required.**</p> |
There was a problem hiding this comment.
You also need to remove the <p> tags
Removed the p tag from block class requirement note.
|
|
|
P tag has been removed @jeff-matthews |
Edited for grammar and punctuation.
bdenham
approved these changes
May 31, 2018
jeff-matthews
approved these changes
May 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the formatting of the block class required message.
This PR is a:
Summary
When this pull request is merged, it will improve the formatting of the block class note.
I previously used markdown which isn't styling the content as I expected.