Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Removed incorrect instructions for reinstall via composer #3701 #3802

Merged
merged 4 commits into from
Feb 22, 2019

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Feb 21, 2019

This PR is a:

  • Content fix or rewrite

Summary

whatsnew
Removed improper git commands for composer reinstall in Uninstall and Reinstall Magento and links to correct instructions.

@dobooth dobooth added 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc labels Feb 21, 2019
@dobooth dobooth self-assigned this Feb 21, 2019
@dobooth dobooth requested a review from bdenham February 21, 2019 21:58
Copy link
Contributor

@bdenham bdenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with changes.

@dobooth
Copy link
Contributor Author

dobooth commented Feb 22, 2019

running tests

@dobooth dobooth merged commit 25e2dd0 into master Feb 22, 2019
@ghost
Copy link

ghost commented Feb 22, 2019

Hi @dobooth, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the db_3701_composercreate branch February 22, 2019 14:44
@dshevtsov
Copy link
Collaborator

@dobooth, section id is incorrect in a hyperlink in the whatsnew

@dshevtsov
Copy link
Collaborator

Please consider converting HTML to Kramdown when you update old topics like this in future PRs.

@dshevtsov
Copy link
Collaborator

For the consistency with other entries in the Whats New on DevDocs, use the past tense in whatsnew: Removed improper git ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

composer create doesn't initialize /git into install directory
3 participants