Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

MAGECLOUD-2739 update services #5039

Merged
merged 14 commits into from
Jul 30, 2019
Merged

MAGECLOUD-2739 update services #5039

merged 14 commits into from
Jul 30, 2019

Conversation

hguthrie
Copy link
Contributor

@hguthrie hguthrie commented Jul 24, 2019 •
edited
Loading

This PR updates the Configure environments > Services section of the Cloud guide.

  • updated the versions of services to be general in nature and reference the magento cloud template repository for the latest defaults
  • update the service value definitions, specifically the DISK value to be clear about services that require the use of persistent storage
  • updated the procedure for enabling the mysql service
  • clarified the services connection to Relationships in .magento.app.yaml configuration

whatsnew

@hguthrie hguthrie added 2.x Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc labels Jul 24, 2019
@hguthrie hguthrie self-assigned this Jul 24, 2019
NadiyaS
NadiyaS reviewed Jul 25, 2019
View reviewed changes
NadiyaS
NadiyaS reviewed Jul 25, 2019
View reviewed changes
NadiyaS
NadiyaS reviewed Jul 25, 2019
View reviewed changes
andriyShevtsov
andriyShevtsov reviewed Jul 25, 2019
View reviewed changes
@hguthrie
Copy link
Contributor Author

Thank you @NadiyaS and @andriyShevtsov for the review. I'll update!

@hguthrie hguthrie requested a review from meker12 July 26, 2019 21:54
@hguthrie
Copy link
Contributor Author

I removed a confusing piece about "pretty-print", which was actually a verification step to confirm services were setup properly. I placed an explanation in the main Services topic with procedures for local (using the CLI) and for remote (using PHP)... and then I deleted the include-file about pretty-print. I cleaned all other topics by adding a verification step with a link to the explanation.

@hguthrie hguthrie mentioned this pull request Jul 29, 2019
Merged
meker12
meker12 suggested changes Jul 29, 2019
View reviewed changes
guides/v2.2/cloud/project/project-conf-files_services.md
disk: 2048
```

The current default storage amount per project is 5GB, or 5120MB. You can distribute this amount between your application and each of its services.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this per Cloud project, or per environment? I guess Production and Staging would have same amount if dedicated staging is provisioned. The current default storage allocated for "persistent data storage" or all types of storage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an old, leftover comment. I did not look in to this and the technical reviewers did not comment.

hguthrie and others added 2 commits July 29, 2019 15:09
@hguthrie @meker12
Apply suggestions from code review
f795ac6 
Co-Authored-By: Margaret Eker <meker@adobe.com>
@hguthrie
updates from feedback
9fb01eb
meker12
meker12 approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@hguthrie
Copy link
Contributor Author

running tests

@hguthrie hguthrie merged commit 785b6f0 into master Jul 30, 2019
@ghost
Copy link

ghost commented Jul 30, 2019

Hi @hguthrie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hguthrie hguthrie deleted the hg-mc2739-disk-space branch July 30, 2019 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
3 more reviewers

@NadiyaS NadiyaS NadiyaS left review comments

@andriyShevtsov andriyShevtsov andriyShevtsov left review comments

@meker12 meker12 meker12 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@hguthrie hguthrie

@meker12 meker12

Labels
2.x Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hguthrie @meker12 @NadiyaS @andriyShevtsov