MAGEDOC-3966 PHP version update #5046

dobooth · 2019-07-25T20:33:28Z

Purpose of this pull request

Magento 2.3.3 raises the PHP minimum version and includes PHP 7.3 on the upper end.
This PR updates this version number.
It also removes/updates PHP installation steps and cleaned up some duplicative files.
Lots of markdown cleanup and link fixing.

https://jira.corp.magento.com/browse/MAGEDOC-3966
This pull request (PR) ...

Affected DevDocs pages

https://devdocs.magedevteam.com/661/guides/v2.3/install-gde/system-requirements-tech.html

magento-cicd2 · 2019-07-25T20:33:32Z

All committers have signed the CLA.

hguthrie

Tread very carefully in Cloud territory.
You must revert many of these changes.

guides/v2.2/cloud/before/before-workspace-magento-prereqs.md

hguthrie · 2019-07-29T19:46:23Z

guides/v2.2/cloud/project/project-conf-files_magento-app.md

 ```yaml
 build:
-    flavor: composer
+  flavor: composer


PR #5039 will blow this away

Our YAML files may or may not conform to our linter. It depends on the YAML we refer to in the development repo.
Remove all changes to this file.

hguthrie · 2019-07-29T19:54:18Z

guides/v2.3/cloud/before/before-workspace-magento-prereqs.md

+1. Find your `php.ini` file using the following command:

-		php --ini
+    php --ini


Formatting here should be a code block.

hguthrie · 2019-07-29T19:54:55Z

guides/v2.3/cloud/before/before-workspace-magento-prereqs.md

-3.	Change the value of `memory_limit` to at least `1G` for normal use or at least `2G` for debugging.
-4.	Save your changes to `php.ini` and exit the text editor.
-5.	Restart your web server:
+  Use the value of `Loaded Configuration File`.


None of these old steps are confirmed accurate. I would drop edits to this old file.

I will revert this file.

guides/v2.3/cloud/before/before-workspace-magento-prereqs.md

jeff-matthews

@dobooth

It's very difficult to review PRs this large. Many changes affect formatting only and should be made separately in the future. I stopped commenting on all the formatting instances that require code fences, but that are everywhere.

I'd like to review again after you fix the self-redirect issue that's preventing the php-settings.html file from rendering on staging.

guides/v2.2/cloud/project/project-conf-files_magento-app.md

guides/v2.2/comp-mgr/trouble/cman/out-of-memory.md

guides/v2.2/config-guide/deployment/pipeline/build-system.md

guides/v2.2/install-gde/prereq/nginx.md

guides/v2.2/install-gde/prereq/optional.md

guides/v2.2/install-gde/prereq/php-settings.md

Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>

…hp_upgrade

dobooth · 2019-07-30T16:46:38Z

Removed cloud topics. Fixed code fences. Fixed recursive redirect.

hguthrie

You are hereby released from Cloud lockdown.

guides/v2.3/install-gde/prereq/php-settings.md

dobooth · 2019-07-31T20:28:18Z

running tests

…hp_upgrade

guides/v2.2/cloud/before/before-workspace-magento-prereqs.md

hguthrie · 2019-08-01T13:45:53Z

guides/v2.3/cloud/before/before-workspace-magento-prereqs.md

 ## PHP (local) {#php}

-Install [PHP](https://glossary.magento.com/php) on your local. We recommend PHP 7.1.3+ or 7.2. For information on installing PHP on CentOS and Ubuntu see [PHP](../../../v2.3/install-gde/prereq/php-centos-ubuntu.html). For instructions for another OS, see the [PHP documentation](http://php.net/manual/en/install.php).
+Install [PHP](https://glossary.magento.com/php) on your local. We recommend PHP 7.1.3+ or 7.2. For information on installing PHP see [PHP Settings]({{ page.baseurl }}/install-gde/prereq/php-settings.md). For instructions for another OS, see the [PHP documentation](http://php.net/manual/en/install.php).


HTML instead of MD

guides/v2.2/cloud/before/before-workspace-magento-prereqs.md

guides/v2.3/cloud/before/before-workspace-magento-prereqs.md

Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>

dobooth · 2019-08-01T16:01:43Z

running tests

ghost · 2019-08-01T16:33:08Z

Hi @dobooth, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

dobooth added 5 commits July 24, 2019 16:06

Upgrading PHP version. MD fix-ups.

e01debb

Merge master

99d09a5

Fixed links and markdown errors.

184e8af

Small fixes.

27b40a8

Merge branch 'master' into db_php_upgrade

c120422

dobooth self-assigned this Jul 25, 2019

dobooth added xx2.3.3 Magento 2.3.3 changes Technical Updates to the code or processes that alter the technical content of the doc labels Jul 25, 2019

dobooth added 2 commits July 29, 2019 14:05

Merge branch 'develop' into db_php_upgrade

bdc27f0

Merge branch 'develop' into db_php_upgrade

eef2c9e

dobooth requested a review from jeff-matthews July 29, 2019 19:12

hguthrie suggested changes Jul 29, 2019

View reviewed changes

m2-community-project bot assigned hguthrie Jul 29, 2019

jeff-matthews suggested changes Jul 29, 2019

View reviewed changes

m2-community-project bot assigned jeff-matthews Jul 29, 2019

dobooth and others added 8 commits July 30, 2019 10:21

Update guides/v2.2/cloud/before/before-workspace-magento-prereqs.md

6db1e2f

Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>

Added innumberable codeblocks. Fixed redirect.

8cc884c

Update guides/v2.2/install-gde/prereq/php-settings.md

4ae4c58

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>

Merge branch 'develop' into db_php_upgrade

92b301b

Code block

bac1cc5

Code fence

709fbda

remove cloud topic

ce855de

Merge branch 'db_php_upgrade' of github.com:magento/devdocs into db_p…

cf6b3ff

…hp_upgrade

hguthrie approved these changes Jul 30, 2019

View reviewed changes

hguthrie removed their assignment Jul 30, 2019

jeff-matthews suggested changes Jul 30, 2019

View reviewed changes

guides/v2.3/install-gde/prereq/php-settings.md Outdated Show resolved Hide resolved

dobooth added 2 commits July 31, 2019 11:12

Merge branch 'develop' into db_php_upgrade

1739716

Removed recursive redirects.

17a6bb2

Fixed broken data links.

64fb3e1

jeff-matthews approved these changes Jul 31, 2019

View reviewed changes

Merge branch 'develop' into db_php_upgrade

0e3d36f

dobooth added 2 commits July 31, 2019 16:00

Fixed up broken links.

c7b660a

Merge branch 'db_php_upgrade' of github.com:magento/devdocs into db_p…

489cc96

…hp_upgrade

m2-community-project bot added the Progress: approved label Jul 31, 2019

hguthrie reviewed Aug 1, 2019

View reviewed changes

guides/v2.2/cloud/before/before-workspace-magento-prereqs.md Outdated Show resolved Hide resolved

m2-community-project bot assigned hguthrie Aug 1, 2019

m2-community-project bot added Progress: review and removed Progress: approved labels Aug 1, 2019

hguthrie reviewed Aug 1, 2019

View reviewed changes

guides/v2.2/cloud/before/before-workspace-magento-prereqs.md Outdated Show resolved Hide resolved

guides/v2.3/cloud/before/before-workspace-magento-prereqs.md Outdated Show resolved Hide resolved

dobooth and others added 4 commits August 1, 2019 09:01

Update guides/v2.3/cloud/before/before-workspace-magento-prereqs.md

33dade4

Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>

Update guides/v2.2/cloud/before/before-workspace-magento-prereqs.md

45bd7a5

Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>

Merge branch 'develop' into db_php_upgrade

227fbb6

Merge branch 'develop' into db_php_upgrade

5c138bd

dobooth merged commit 397f215 into develop Aug 1, 2019

m2-community-project bot removed the Progress: review label Aug 1, 2019

dobooth deleted the db_php_upgrade branch August 1, 2019 16:33

MAGEDOC-3966 PHP version update #5046

MAGEDOC-3966 PHP version update #5046

Uh oh!

Conversation

dobooth commented Jul 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this pull request

Affected DevDocs pages

Uh oh!

magento-cicd2 commented Jul 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hguthrie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hguthrie Jul 29, 2019

Choose a reason for hiding this comment

Uh oh!

dobooth Jul 30, 2019

Choose a reason for hiding this comment

Uh oh!

hguthrie Jul 29, 2019

Choose a reason for hiding this comment

Uh oh!

hguthrie Jul 29, 2019

Choose a reason for hiding this comment

Uh oh!

dobooth Jul 30, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jeff-matthews left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dobooth commented Jul 30, 2019

Uh oh!

hguthrie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dobooth commented Jul 31, 2019

Uh oh!

Uh oh!

hguthrie Aug 1, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dobooth commented Aug 1, 2019

Uh oh!

ghost commented Aug 1, 2019

Uh oh!

Uh oh!

dobooth commented Jul 25, 2019 •

edited

Loading

magento-cicd2 commented Jul 25, 2019 •

edited

Loading