-
Notifications
You must be signed in to change notification settings - Fork 1.7k
magento/devdocs#3361: Configuration object topic #6514
Conversation
An admin must run tests on this PR before it can be merged. |
1 similar comment
An admin must run tests on this PR before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @atwixfirster. Thank you for your collaboration. The example is very useful. In order to answer all questions from the original issue, we need to add a little bit more information. Please, check the following suggestions.
It would be great if we leave a reference in this topic to the following topic so developers will know where to go for the detailed information.
Then, the following topic describes the general idea of the configuration file merge.
It would be awesome if we could have a few sentences about how to see (debug) the merged configuration. So, the question is if a developer wants to verify that a custom configuration is present in the merged config, what he is going to do?
Thank you!
Thanks for picking this up @atwixfirster! |
Hi, @shrielenee ! Looks like my PR has pushed @diazwatson to work on the #3361 again. :) So, to avoid a double work I will probably stop my work on this one and will wait for the @diazwatson updates (see PR #6516). Thank you! |
Whoever wants to do it is fine by us! @atwixfirster @diazwatson It was just such an easy grab... so you can fight it out over this one 👊 😄 |
609d389
to
13393ce
Compare
The appropriate link has been added.
The appropriated callout block has been added with reference to debug entry point. @rogyar , could you please review? Thank you! |
1 similar comment
The appropriate link has been added.
The appropriated callout block has been added with reference to debug entry point. @rogyar , could you please review? Thank you! |
Hi @atwixfirster, thank you for your contribution! |
From a technical perspective, the information in the current PR is correct. However, we have another PR with more extended information on the same matter. The advantage of the current PR is the creation time. The advantage of the PR mentioned above is richer information. I'm not sure about the fair decision here. We could either ask @atwixfirster to extend info in this PR and accept it as a preceding one or accept the last one from @diazwatson. @dobooth could you assist in this tricky decision, please? :) Thank you! |
Happy to arbitrate here, gents. This is the kind of debate we like! Thanks to @rogyar for having a great awareness of what's happening in the repo. And thanks to you all for your continued efforts. I am going to go with #6539 since it does seem to have a bit more data. I will head over there and clean up those linting errors... 😉 |
Hi @dobooth. Thanks a lot for your arbitration 👍 |
Closing. This was handled in another PR. |
Hi @atwixfirster, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) fixes #3361.
Affected DevDocs pages
Links to Magento source code
whatsnew
Added an example to Create or extend configuration types.