Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

diazwatson
Copy link
Contributor

@diazwatson diazwatson commented Jan 31, 2020

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

1 similar comment
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@diazwatson diazwatson requested a review from rogyar February 2, 2020 11:13
@diazwatson
Copy link
Contributor Author

Hi @rogyar this PR should contain all the changes you recommended me t apply in a previous PR. Could you please have a look and let me know if so see something missing? Thanks

Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @diazwatson. I'm not sure how you were able to create an exact copy of the existing guide :)
guides/v2.3/config-guide/config/config-files.md already exists but this PR shows it as a new file. Maybe there's an issue in the file path (encoding issue) or so.

Also, please, take a look at the review for PR with the same idea. There are some additional ideas that need to be implemented in order to cover all the information requested in the original issue.

Thank you

@diazwatson
Copy link
Contributor Author

Thanks, I'll have a look

@atwixfirster
Copy link
Contributor

@diazwatson , a correct file location - src/guides/v2.3/config-guide/config/config-files.md

Please pull the latest changes from master branch!

Thank you!

@diazwatson
Copy link
Contributor Author

Thanks @atwixfirster I got confused because one of the initial recommendation was to add this changes to 2.2 and 2.3 and it was valid for both versions. I'll update this PR with the correct location today. 👍

@atwixfirster
Copy link
Contributor

I got confused because one of the initial recommendation was to add this changes to 2.2 and 2.3 and it was valid for both versions.

@diazwatson please note, what we do not accept PRs with updates for 2.2 version. So, please add your updates for 2.3 only.

Thanks

@diazwatson
Copy link
Contributor Author

Closing in favour of #6514

@diazwatson diazwatson closed this Feb 4, 2020
@ghost
Copy link

ghost commented Feb 4, 2020

Hi @diazwatson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants