Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Mar 2, 2020

  • For MFTF, add details about *Meta.xml file naming.

Purpose of this pull request

Affected DevDocs pages

  • Technical Guidelines

- Add details about `*Meta.xml` file naming.
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

- Fix spaces after list marker
@tomreece
Copy link
Contributor Author

tomreece commented Mar 2, 2020

This rule checks for the number of spaces between a list marker (e.g. '-', '*', '+' or '1.') and the text of the list item.
The number of spaces checked for depends on the document style in use, but the default is 1 space after any list marker

I have one space after my list item markers.

I don't know what this linter wants me to do. Please advise @dobooth.

@jeff-matthews
Copy link
Contributor

@tomreece, here's a list of our rules, specifically for rule 30: https://github.com/magento/devdocs/blob/master/_checks/styles/style-rules-prod#L26

We require two spaces between the marker and text for first-level unordered lists.

- Added two spaces after list markers
@tomreece
Copy link
Contributor Author

tomreece commented Mar 2, 2020

@jeff-matthews Thanks! I fixed it. 👍

@dobooth dobooth self-assigned this Mar 2, 2020
@dobooth dobooth added 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc labels Mar 2, 2020
@dobooth
Copy link
Contributor

dobooth commented Mar 3, 2020

running tests

@dobooth dobooth merged commit 1b0692e into magento:master Mar 3, 2020
@ghost
Copy link

ghost commented Mar 3, 2020

Hi @tomreece, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants