Skip to content

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Feb 28, 2020

Need to update technical guidelines.

Related PRs to MFTF-3.0.0 develop branches:

Build
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/30315/

The above build has failures, but they are equivalent to the MFTF-3.0.0 branch failures.

@coveralls
Copy link

coveralls commented Feb 28, 2020

Coverage Status

Coverage remained the same at 50.883% when pulling a406a6f on MQE-1057 into 3a18c6b on develop.

@soumyau soumyau self-requested a review March 3, 2020 16:14
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could see a couple more usages of -meta.xml in mftf. Can you please check if they need to be renamed as well -
MetadataGenerator.php => generateMetaDataFile, comment block of $filepath
MetadataGenUtil.php => __construct, comment block of $filepath

@tomreece
Copy link
Contributor Author

tomreece commented Mar 3, 2020

Could see a couple more usages of -meta.xml in mftf. Can you please check if they need to be renamed as well -

Those files are outdated and unused. I did not touch these files because they should be removed from our framework. If I fix the comment, I have to fix the implementation of those which generate -meta.xml files and we never test that code.

Is it ok if I leave it as-is?

@tomreece tomreece requested a review from soumyau March 3, 2020 20:02
@tomreece tomreece merged commit 4462b2c into develop Mar 3, 2020
@tomreece tomreece deleted the MQE-1057 branch April 30, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants