Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

adifucan
Copy link
Contributor

@adifucan adifucan commented May 18, 2020

Purpose of this pull request

This pull request (PR) introduces image lazy loading mechanism

Affected DevDocs pages

  • src/guides/v2.4/frontend-dev-guide/themes/theme-images.md

Links to Magento source code

Here is a PR with this functionality to 2.4-develop: https://github.com/magento/magento2ce/pull/5674

whatsnew
Added the 'Image lazy loading' section to the Configure theme properties.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@dmytro-ch
Copy link
Contributor

Hello @adifucan.
Unfortunately, I didn't find the related PR in magento/magento2 repository.
Could you please check the related PR's link in the description? It seems to be broken. Does this link work for you?

@dobooth
Copy link
Contributor

dobooth commented May 19, 2020

The PR link is correct but it points to a private repo.

@adifucan
Copy link
Contributor Author

Currently PR with this functionality is located in private magento/magento2ce repo. Once it will be merged there, it will be available in public magento/magento2 repo after sync.

@dobooth dobooth added 2.4.0 Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content labels May 27, 2020
@dobooth
Copy link
Contributor

dobooth commented May 27, 2020

running tests

@dobooth dobooth merged commit 06f4633 into magento:2.4.0-develop May 27, 2020
@ghost
Copy link

ghost commented May 27, 2020

Hi @adifucan, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the lazy-loading branch May 27, 2020 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.4.0 Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants