Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Jul 29, 2020

Purpose of this pull request

Removed blank line from metadata that caused page to render incorrectly.

Affected DevDocs pages

@meker12 meker12 self-assigned this Jul 29, 2020
@meker12 meker12 added the Internal Dev Differentiates work between community and Magento staff label Jul 29, 2020
@meker12 meker12 added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies 2.x and removed Progress: review labels Jul 29, 2020
@meker12 meker12 mentioned this pull request Jul 29, 2020
@meker12
Copy link
Contributor Author

meker12 commented Jul 29, 2020

running tests

@meker12
Copy link
Contributor Author

meker12 commented Jul 29, 2020

running tests

@meker12
Copy link
Contributor Author

meker12 commented Jul 30, 2020

running tests

@meker12 meker12 requested a review from dobooth July 30, 2020 03:49
@ghost
Copy link

ghost commented Jul 30, 2020

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the mae-fix-contributor-attribution branch July 30, 2020 10:47
@jeff-matthews
Copy link
Contributor

@meker12, that page still appears to be broken.

@meker12
Copy link
Contributor Author

meker12 commented Jul 30, 2020

It builds and works locally. In my browser, it still says that the page was updated 36 hours ago, even though I refreshed. Am looking again. Running another production build to deploy all changed files. Maybe the metadata change isn't getting picked up with the changed files build.

@jeff-matthews
Copy link
Contributor

Ah, yes. I think you're right about the deployment option. You should select the all parameter on the devdocs-production pipeline.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2.x Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Internal Dev Differentiates work between community and Magento staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants