Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

kalpmehta
Copy link
Contributor

@kalpmehta kalpmehta commented Jul 29, 2020

Purpose of this pull request

Added contributor acknowledgement for contributing content to the new security.txt file documentation.

Affected DevDocs pages

magento community contribution callout
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@meker12
Copy link
Contributor

meker12 commented Jul 29, 2020

@kalpmehta Please complete the PR description to add description, files affected, and a link to source code associated with this change. Thx.

@ccondra
Copy link
Contributor

ccondra commented Jul 29, 2020

This topic was based primarily on the readme from Corra's code contribution, so their contribution to the documentation should be acknowledged! However, it goes in the meta data, rather than in a callout. See the metadata parameters in this topic, and then update your meta data and remove the callout. Thanks!
https://devdocs.magento.com/contributor-guide/templates/basic_template.html#metadata-parameters

@meker12 meker12 self-assigned this Jul 29, 2020
@meker12 meker12 changed the base branch from master to small-changes July 29, 2020 15:22
@meker12 meker12 merged commit 626c511 into small-changes Jul 29, 2020
@ghost
Copy link

ghost commented Jul 29, 2020

Hi @kalpmehta, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12
Copy link
Contributor

meker12 commented Jul 29, 2020

@kalpmehta Thanks for reminding us to acknowledge your contribution. I went ahead and added the metadata for the acknowledgement. Changes ought to be published in next day or two.

meker12 added a commit that referenced this pull request Jul 29, 2020
* Update mage-profiler.md

fix repetitive words.

* Updates for New Relic Logs documentation (#7614)

* Updates for New Relic Logs documentation:
- Revised introduction to View and manage logs topic
- Updated the screen capture to access New Relic Logs from the APM
application view to show callout for Logs selection
- Miscellaneous edits
* Editorial change

* Cloud Guide fixes (#7586)

* Fix broken links

Fix broken links mentioned in HotJar feedback.

* Rename fastly-vcl-whitelist.md to fastly-vcl-allowlist.md

Co-authored-by: maeker12 <{ID}+{username}@users.noreply.github.com>

* Update supported ES versions for  Magento 2.4 (#7567)

- Removed 7.4.x from support matrix
- Cloud supports only 7.2, 7.5, and 7.6

* Correct font display values (#7590)

Co-authored-by: Tu Nguyen <tuna@ecommage.com>

* Clarify context for using mgc log command

* Update security-txt.md (#7615)

* Update security-txt.md to add contributor acknowledgement

Co-authored-by: Margaret Eker <meker@adobe.com>
Co-authored-by: Zeeshan Khuwaja <zeeshan2523806@users.noreply.github.com>
Co-authored-by: Tu Nguyen <ladiesman9x@gmail.com>
Co-authored-by: Tu Nguyen <tuna@ecommage.com>
Co-authored-by: Donald Booth <dobooth@adobe.com>
Co-authored-by: Kalpesh Mehta <kmehta@corra.com>
@meker12 meker12 deleted the kalpmehta-patch-1 branch July 29, 2020 16:42
@ccondra ccondra self-requested a review July 29, 2020 16:43
@kalpmehta
Copy link
Contributor Author

@ccondra @meker12 I added the callout after checking other similar pages. Example can be found here: https://devdocs.magento.com/guides/v2.4/security/two-factor-authentication.html

Please note, this is not only about the DevDocs article contribution, but also the Security.txt module contribution to the core codebase as well :)
Original PR of the security.txt module: magento/security-package#1

Thank you.

@kalpmehta
Copy link
Contributor Author

FYI the page broke after the merge: https://devdocs.magento.com/guides/v2.4/security/security-txt.html

@jeff-matthews
Copy link
Contributor

@meker12, I think it's because there's an extra line in the metadata block.

@meker12
Copy link
Contributor

meker12 commented Jul 29, 2020

Thanks for the heads up -- submitted #7628 to fix. Building on staging to test. Will publish when fix is available @kalpmehta.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants