Skip to content

MAGECLOUD-5472: Patch MAGECLOUD-5069__fpc_is_getting_disabled_during_deployments can't be applied on 2.3.5 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2020
Merged

MAGECLOUD-5472: Patch MAGECLOUD-5069__fpc_is_getting_disabled_during_deployments can't be applied on 2.3.5 #30

merged 2 commits into from
Mar 4, 2020

Conversation

dyushkin
Copy link
Contributor

@dyushkin dyushkin commented Mar 3, 2020 •
edited
Loading

MAGECLOUD-5472: Patch MAGECLOUD-5069__fpc_is_getting_disabled_during_deployments can't be applied on 2.3.5

Description

Fix for MAGECLOUD-5069 for Magento 2.3.5

Fixed Issues (if relevant)

  1. https://magento2.atlassian.net/browse/MAGECLOUD-5472
  2. https://magento2.atlassian.net/browse/MAGECLOUD-5069

Manual testing scenarios

  1. Install Magento v2.3.5
  2. Performing bin/magento maintenance:enable CLI command.
  3. full_page flag in app/etc/env.php isn't becoming 0 (previously it was)
  4. Performing bin/magento maintenance:disable CLI command.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dyushkin dyushkin changed the title MAGECLOUD-5472: Patch MAGECLOUD-5069__fpc_is_getting_disabled_during_… MAGECLOUD-5472: Patch MAGECLOUD-5069__fpc_is_getting_disabled_during_deployments can't be applied on 2.3.5 Mar 3, 2020
BaDos
BaDos previously approved these changes Mar 3, 2020
View reviewed changes
oshmyheliuk
oshmyheliuk previously approved these changes Mar 3, 2020
View reviewed changes
@andriyShevtsov andriyShevtsov self-assigned this Mar 3, 2020
@andriyShevtsov
Copy link
Collaborator

QA approved

@andriyShevtsov andriyShevtsov added the Progress: approved PR/issue status label Mar 3, 2020
@shiftedreality shiftedreality dismissed stale reviews from oshmyheliuk and BaDos March 4, 2020 14:48

The base branch was changed.

@shiftedreality shiftedreality changed the base branch from develop to 1.0 March 4, 2020 14:48
@shiftedreality shiftedreality merged commit 2a3e248 into magento:1.0 Mar 4, 2020
@YPyltiai YPyltiai added Release: 1.0.3 MCP Release and removed Release Line: 1.0 labels Mar 4, 2020
@meker12 meker12 mentioned this pull request Apr 16, 2020
Merged
@shiftedreality shiftedreality mentioned this pull request Apr 20, 2020
Closed
@magento-cloud-ft-jenkins-svc
Copy link

Functional Acceptance Test Results

❌  One or more functional acceptance tests have failed.

PHP 7.1

❓  No scenario results found

PHP 7.2

❓  No scenario results found

PHP 7.3

❓  No scenario results found

PHP 7.4

❓  No scenario results found

Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details.

This comment was generated by Jenkins job magento-cloud-patches/functional build 34.

magento-cicd2 pushed a commit that referenced this pull request Jul 19, 2021
@sidolov
Community patches & Category support (#30)
e334c98
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
@shiftedreality
Merge pull request #30 from dyushkin/MAGECLOUD-5472
b587d9c 
MAGECLOUD-5472: Patch MAGECLOUD-5069__fpc_is_getting_disabled_during_deployments can't be applied on 2.3.5
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
@sidolov
Community patches & Category support (#30)
7e32e81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@BaDos BaDos BaDos approved these changes

@oshmyheliuk oshmyheliuk oshmyheliuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andriyShevtsov andriyShevtsov

Labels

Progress: approved PR/issue status Release: 1.0.3 MCP Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dyushkin @andriyShevtsov @magento-cloud-ft-jenkins-svc @BaDos @oshmyheliuk @shiftedreality @YPyltiai