Skip to content

MCLOUD-5701 / MCLOUD-5375: Fix cloud patches #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2020
Merged

MCLOUD-5701 / MCLOUD-5375: Fix cloud patches #35

merged 3 commits into from
Apr 15, 2020

Conversation

BaDos
Copy link
Contributor

@BaDos BaDos commented Apr 13, 2020 •
edited
Loading

Description

This PR contains the fixes of the next patches for Magento CE:

  • MAGECLOUD-3913__fix_problems_with_consumer_runners_on_cloud_clusters
  • MAGECLOUD-2033__prevent_deadlock_during_db_dump
  • MAGECLOUD-4071__terminate_consumers_if_the_queue_is_empty

Fixed Issues (if relevant)

  1. https://jira.corp.magento.com/browse/MCLOUD-5375
  2. https://jira.corp.magento.com/browse/MCLOUD-5701

Manual testing scenarios

None

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@BaDos BaDos changed the title MCLOUD-5701: Fix cloud patches MCLOUD-5701 / MCLOUD-5375: Fix cloud patches Apr 13, 2020
@BarnyShergold
Copy link

As there are now Maintainers that do not have access to Magento JIRA, please can you add a description to the Pull Request?

@BaDos BaDos added the Progress: review PR/issue status label Apr 15, 2020
@BaDos
Copy link
Contributor Author

BaDos commented Apr 15, 2020

No need QA, covered with FT.

@shiftedreality shiftedreality added Progress: approved PR/issue status Release: 1.0.4 and removed Progress: review PR/issue status labels Apr 15, 2020
@shiftedreality shiftedreality merged commit 11eb2d9 into develop Apr 15, 2020
@shiftedreality shiftedreality deleted the MCLOUD-5701 branch April 15, 2020 14:30
@magento-cloud-ft-jenkins-svc
Copy link

Functional Acceptance Test Results

❌  One or more functional acceptance tests have failed.

PHP 7.1

❓  No scenario results found

PHP 7.2

❓  No scenario results found

PHP 7.3

❓  No scenario results found

PHP 7.4

❓  No scenario results found

Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details.

This comment was generated by Jenkins job magento-cloud-patches/functional build 48.

@magento-cloud-ft-jenkins-svc
Copy link

Functional Acceptance Test Results

❌  One or more functional acceptance tests have failed.

PHP 7.1

❓  No scenario results found

PHP 7.2

❓  No scenario results found

PHP 7.3

❓  No scenario results found

PHP 7.4

❓  No scenario results found

Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details.

This comment was generated by Jenkins job magento-cloud-patches/functional build 49.

magento-devops-reposync-svc pushed a commit that referenced this pull request Jul 23, 2021
@nathanjosiah
MC-42674 (#35)
4c9ea73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@shiftedreality shiftedreality shiftedreality approved these changes

@oshmyheliuk oshmyheliuk oshmyheliuk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Progress: approved PR/issue status Release: 1.0.4 release-note-completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BaDos @BarnyShergold @magento-cloud-ft-jenkins-svc @shiftedreality @oshmyheliuk @meker12