AC-674: Create phpcs static check for ObsoleteAclTest

- Refactor: Get rid of elementIsCurrentlySniffedLine

Author: loginesta

Magento2/Sniffs/Legacy/ObsoleteAclSniff.php

@@ -8,7 +8,6 @@
 use DOMDocument;
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Sniffs\Sniff;
-use SimpleXMLElement;
 
 /**
  * Test to find obsolete acl declaration
@@ -32,37 +31,21 @@ public function register(): array
      */
     public function process(File $phpcsFile, $stackPtr)
     {
+        if ($stackPtr > 0) {
+            return;
+        }
+
         $xml = simplexml_load_string($this->getFormattedXML($phpcsFile));
         $foundElements = $xml->xpath('/config/acl/*[boolean(./children) or boolean(./title)]');
         foreach ($foundElements as $element) {
-            if (!$this->elementIsCurrentlySniffedLine($element, $stackPtr)) {
-                continue;
-            }
-
             $phpcsFile->addWarning(
-                'Obsolete acl structure detected in line ' . ($stackPtr + 1),
-                $stackPtr,
+                'Obsolete acl structure detected in line ' . dom_import_simplexml($element)->getLineNo(),
+                dom_import_simplexml($element)->getLineNo() - 1,
                 self::WARNING_OBSOLETE_ACL_STRUCTURE
             );
         }
     }
 
-    /**
-     * Check if the element passed is in the currently sniffed line
-     *
-     * @param SimpleXMLElement $element
-     * @param int $stackPtr
-     * @return bool
-     */
-    private function elementIsCurrentlySniffedLine(SimpleXMLElement $element, int $stackPtr): bool
-    {
-        $node = dom_import_simplexml($element);
-        if ($node->getLineNo() === $stackPtr+1) {
-            return true;
-        }
-        return false;
-    }
-
     /**
      * Format the incoming XML to avoid tags split into several lines.
      *

Magento2/Tests/Legacy/ObsoleteAclUnitTest.php

@@ -24,7 +24,8 @@ public function getWarningList(): array
     {
         return [
             15 => 1,
-            20 => 1
+            20 => 1,
+            23 => 1
         ];
     }
 }

Magento2/Tests/Legacy/ObsoleteAclUnitTest.xml

@@ -20,5 +20,9 @@
         <title>
             <children default_policy="deny"/>
         </title>
+        <children>
+            <title
+                    value="foo"/>
+        </children>
     </acl>
 </config>