AC-661: Create phpcs static check for XmlTest #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svera
suggested changes
Sep 9, 2021
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
svera
suggested changes
Sep 9, 2021
Contributor
|
Also provide a description for the PR |
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
loginesta
reviewed
Sep 9, 2021
Contributor
loginesta
left a comment
loginesta
left a comment
There was a problem hiding this comment.
you can run the following in advance vendor/bin/phpcs --standard=Magento2 Magento2/Helpers/ Magento2/Sniffs, prior to pushing changes to your PR
svera
suggested changes
Sep 9, 2021
Contributor
svera
left a comment
svera
left a comment
There was a problem hiding this comment.
This case is still missing, I was referring to badly formatted XML file, not wrong XML:
Include another file like this, but having the translate attribute in a new line to check also badly formatted XML files
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
loginesta
previously approved these changes
Sep 9, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
svera
reviewed
Sep 13, 2021
svera
approved these changes
Sep 13, 2021
Contributor
Author
|
@magento import pr to magento-commerce/magento-coding-standard |
Contributor
|
@jcuerdo the pull request successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\Magento\Test\Legacy\Magento\Widget\XmlTest test for backwards-incompatible change in widget.xml structure