Skip to content

MFTF. Fixed page URL reference and completion, added test coverage #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2020
Merged

MFTF. Fixed page URL reference and completion, added test coverage #148

merged 2 commits into from
Apr 14, 2020

Conversation

VitaliyBoyko
Copy link
Contributor

FIxed MFTF Page reference and completion, added test coverage.

Fixed Issues (if relevant)

  1. MFTF: Page (URL) reference and autocomplete #105: MFTF: Page (URL) reference and autocomplete

Page URL in test

image

Page URL in action group

image

@eduard13 eduard13 self-assigned this Apr 13, 2020
eduard13
eduard13 requested changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VitaliyBoyko, thank you very much for this improvement. However, I'm getting the following results when typing the page name.
image

We should see here only the urls.
Thank you.

@VitaliyBoyko
Copy link
Contributor Author

VitaliyBoyko commented Apr 13, 2020 •
edited
Loading

Hi @eduard13
There no restrictions for any other attributes usage.
For example (Magento/Bundle/Test/Mftf/Test/AdminAddBundleItemsTest.xml:128):

   <amOnPage url="{{BundleProduct.urlKey}}.html" stepKey="GoToProductPageAgain"/>

Thank you for review. Let me know if I'm wrong.

@VitaliyBoyko VitaliyBoyko requested a review from eduard13 April 13, 2020 19:05
@VitaliyBoyko
Copy link
Contributor Author

Hi @eduard13
I've adjusted the completion.
image

In order to recheck the functionality run the manual reindex:
image

Thank you!

eduard13
eduard13 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@VitaliyBoyko VitaliyBoyko merged commit aea6433 into 1.0.0-develop Apr 14, 2020
@VitaliyBoyko VitaliyBoyko deleted the 105-fixed-page-url-autocomplete branch April 14, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

Labels
Award: test coverage Medium Partner: Atwix partners-contribution release-1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VitaliyBoyko @eduard13 @magento-engcom-team