Skip to content

#169 :- Quick fix for Resolver inspection adds implement directive to the next line #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 22, 2020
Merged

#169 :- Quick fix for Resolver inspection adds implement directive to the next line #175

merged 7 commits into from
Apr 22, 2020

Conversation

konarshankar07
Copy link
Contributor

@konarshankar07 konarshankar07 commented Apr 19, 2020 •
edited
Loading

Description (*)

This PR will add following interface to implement resolver

  1. Magento\Framework\GraphQl\Query\ResolverInterface
  2. Magento\Framework\GraphQl\Query\Resolver\BatchResolverInterface
  3. Magento\Framework\GraphQl\Query\Resolver\BatchServiceContractResolverInterface

Fixed Issues (if relevant)

  1. Quick fix for Resolver inspection adds implement directive to the next line #169: Quick fix for Resolver inspection adds implement directive to the next line

Screenshot

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

Note

I'm not able to reproduce the issue with the interface applied to the next line. I will check again this issue

@konarshankar07 konarshankar07 changed the title #169 :- Quick fix for Resolver inspection adds implement directive to the next line [WIP] :- #169 :- Quick fix for Resolver inspection adds implement directive to the next line Apr 19, 2020
VitaliyBoyko
VitaliyBoyko requested changes Apr 19, 2020
View reviewed changes
src/com/magento/idea/magento2plugin/magento/files/GraphQlResolver.java Outdated
@@ -6,5 +6,7 @@

public class GraphQlResolver {
public static final String RESOLVER_INTERFACE = "\\Magento\\Framework\\GraphQl\\Query\\ResolverInterface";
public static final String BATCH_RESOLVER_INTERFACE = "\\Magento\\Framework\\GraphQl\\Query\\Resolver\\BatchResolverInterface";
public static final String BATCH_SERVICE_CONTRACT_RESOLVER_INTERFACE = "\\Magento\\Framework\\GraphQl\\Query\\Resolver\\BatchServiceContractResolverInterface";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it in my PR. Please fix the only issue with a line in Quick Fix. Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, But I have improved the quick fix with adding a select box to select one of the expected interfaces currenly quick fix is only added for \Magento\Framework\GraphQl\Query\ResolverInterface.
Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, great job

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still in progress?

@konarshankar07
Copy link
Contributor Author

I've tested regading the new line issue and I'm not able to reproduce in the debugger
https://www.loom.com/share/231427f592744559b6bb79ce1faa936b
Please check
Do you know how we can debug the plugin in PhpStorm ?
Thanks

@VitaliyBoyko
Copy link
Contributor

VitaliyBoyko commented Apr 20, 2020 •
edited
Loading

Unfortunately, we have no toolset for PHP storm.
Let me check it once again.

@VitaliyBoyko
Copy link
Contributor

Being reproduced in IntelliJ as well:
Apr-20-2020 15-56-58

@VitaliyBoyko
Copy link
Contributor

@konarshankar07
I'll try to fix it.

@konarshankar07
Copy link
Contributor Author

Sorry, I forgot to mention you that now I'm able to reproduce this issue and working on it

@konarshankar07 konarshankar07 changed the title [WIP] :- #169 :- Quick fix for Resolver inspection adds implement directive to the next line #169 :- Quick fix for Resolver inspection adds implement directive to the next line Apr 22, 2020
@VitaliyBoyko VitaliyBoyko self-requested a review April 22, 2020 07:06
@VitaliyBoyko VitaliyBoyko merged commit 65be14c into magento:1.0.0-develop Apr 22, 2020
@konarshankar07 konarshankar07 deleted the additional-fix-added-for-grapql-resolver--task-169 branch April 22, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBoyko VitaliyBoyko VitaliyBoyko approved these changes

Assignees

@VitaliyBoyko VitaliyBoyko

Labels
Easy Expert inspection release-1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konarshankar07 @VitaliyBoyko