Test coverage for type name attribute completion, linemarker and reference in the di.xml #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker and reference in the di
VitaliyBoyko
requested changes
Apr 22, 2020
| } | ||
|
|
||
| public void testRegularPhpClassShouldNotHaveLinemarker() { | ||
| String filePath = this.getFixturePath("TestNotLineMarker.php"); |
There was a problem hiding this comment.
Suggested change
| String filePath = this.getFixturePath("TestNotLineMarker.php"); | |
| String filePath = this.getFixturePath("ClassNotConfiguredInDiXml.php"); |
There was a problem hiding this comment.
fixed,
thanks for your review!
VitaliyBoyko
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR covers type name attribute completion, linemarker and reference in the di.xml.
Fixed Issues (if relevant)
Contribution checklist (*)