-
Notifications
You must be signed in to change notification settings - Fork 102
#issue-203-204 Added test coverage for Class Preference generator and preference di.xml generator #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… preference di.xml generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. However, could you please add the copyright annotations?
...m/magento/idea/magento2plugin/actions/generation/generator/PreferenceClassGeneratorTest.java
Show resolved
Hide resolved
...m/magento/idea/magento2plugin/actions/generation/generator/PreferenceDiXmlGeneratorTest.java
Show resolved
Hide resolved
…ML-generator-and-class-preference-generator
...m/magento/idea/magento2plugin/actions/generation/generator/PreferenceClassGeneratorTest.java
Show resolved
Hide resolved
...m/magento/idea/magento2plugin/actions/generation/generator/PreferenceDiXmlGeneratorTest.java
Show resolved
Hide resolved
…ML-generator-and-class-preference-generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serhiyzhovnir could you please fix the failing static tests?
Thanks.
…ML-generator-and-class-preference-generator
…ML-generator-and-class-preference-generator
…ave more then 6 lines
Hi @eduard13 @VitaliyBoyko |
Seems I can't merge it without @eduard13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always here for approving great PRs 😏.
Description (*)
This PR adds test coverage for
com.magento.idea.magento2plugin.actions.generation.generator.PreferenceDiXmlGenerator
andcom.magento.idea.magento2plugin.actions.generation.generator.PreferenceClassGenerator
generators.Fixed Issues (if relevant)
Contribution checklist (*)