Skip to content

Conversation

serhiyzhovnir
Copy link
Contributor

Description (*)
This PR adds test coverage for com.magento.idea.magento2plugin.actions.generation.generator.PreferenceDiXmlGenerator and com.magento.idea.magento2plugin.actions.generation.generator.PreferenceClassGenerator generators.

Fixed Issues (if relevant)

  1. Integration tests: cover class preference generator #203: Integration tests: cover class preference generator
  2. Integration tests: cover preference di.xml generator #204: Integration tests: cover preference di.xml generator

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@serhiyzhovnir serhiyzhovnir changed the title #issue-203-204 Added test coverage for Class {reference generator and preference di.xml generator #issue-203-204 Added test coverage for Class Preference generator and preference di.xml generator Apr 29, 2020
@eduard13 eduard13 self-assigned this Apr 29, 2020
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. However, could you please add the copyright annotations?

…ML-generator-and-class-preference-generator
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhiyzhovnir could you please fix the failing static tests?
Thanks.

@serhiyzhovnir
Copy link
Contributor Author

Hi @eduard13 @VitaliyBoyko
I fixed all errors with static tests and also I had added the excluding for the category/java/documentation.xml/CommentSize rule. This rule throws the error if a method docs comment has more then 6 lines, it's a problem for methods with many arguments.
For this PR it throws the error on this method comment: https://github.com/magento/magento2-phpstorm-plugin/pull/238/files#diff-dc18067fb134408559fa7f2888c01ad8R63-R73.
Could you review this one, please?
Thank you!

@serhiyzhovnir serhiyzhovnir requested a review from eduard13 May 8, 2020 05:25
@VitaliyBoyko
Copy link
Contributor

Seems I can't merge it without @eduard13
Let's wait for him back from the vacation 😄

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always here for approving great PRs 😏.

@VitaliyBoyko VitaliyBoyko merged commit cddca4a into magento:1.0.1-develop May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants