Skip to content

Conversation

VitaliyBoyko
Copy link
Contributor

Description (*)

  • Covered plugin type XML attribute completion and reference navigation by functional tests.
  • Added configs that allows to suppress warnings in the checkstyle checker.
  • Suppressed warnings in com.magento.idea.magento2plugin.completion.xml.XmlCompletionContributor and com.magento.idea.magento2plugin.reference.xml.XmlReferenceContributor as files requires decomposition, performing of it will be possible after full test coverage of completion and reference features.
  • Fixed issue with plugin type completion

Fixed Issues (if relevant)

  1. Test coverage. Cover plugin type attribute completion and reference in the di.xml by tests #133: Test coverage. Cover plugin type attribute completion and reference in the di.xml by tests

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Contributor

@coderimus coderimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VitaliyBoyko thank you for the work well done! 👍

@VitaliyBoyko VitaliyBoyko merged commit 375110d into 1.0.1-develop May 11, 2020
@VitaliyBoyko VitaliyBoyko deleted the 133-plugin-type-test-coverage branch May 11, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test coverage. Cover plugin type attribute completion and reference in the di.xml by tests
3 participants