Skip to content

Conversation

serhiyzhovnir
Copy link
Contributor

Description (*)
This PR adds Cron Group generation action.
Screenshot 2020-05-15 at 12 55 50
Screenshot 2020-05-15 at 12 56 12
Screenshot 2020-05-15 at 12 56 37

Fixed Issues (if relevant)

  1. Action/Code Generation. New cron group generation #178: Action/Code Generation. New cron group generation

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing 🤩.
I've left just couple of comments, please review them.

@serhiyzhovnir
Copy link
Contributor Author

Hi @eduard13
I've added the required changes.
About the validation for negative validation, I don't see an ability to restrict negative values for the numbers fields via component properties.
I think that we can go as it is with validation for negative numbers, but please, let me if you have any ideas regarding it.
Thank you!

@eduard13
Copy link
Contributor

Hi @serhiyzhovnir, thank you for fixes. Indeed there is no way to do this via component properties, however, we may set our own SpinnerNumberModel that allows to define the range and the increment.
I've already added the limitations and lets wait for the tests, after that will approve.

Thank you.

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@VitaliyBoyko VitaliyBoyko merged commit d03cab6 into 1.0.1-develop May 20, 2020
@VitaliyBoyko VitaliyBoyko deleted the issue-178-Cron-Group-Generation branch May 20, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants