-
Notifications
You must be signed in to change notification settings - Fork 102
#issue-178 Add CRON Group Generation action #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing 🤩.
I've left just couple of comments, please review them.
src/com/magento/idea/magento2plugin/actions/generation/dialog/NewCronGroupDialog.form
Outdated
Show resolved
Hide resolved
src/com/magento/idea/magento2plugin/actions/generation/dialog/NewCronGroupDialog.form
Outdated
Show resolved
Hide resolved
src/com/magento/idea/magento2plugin/actions/generation/dialog/NewCronGroupDialog.java
Outdated
Show resolved
Hide resolved
Hi @eduard13 |
Hi @serhiyzhovnir, thank you for fixes. Indeed there is no way to do this via component properties, however, we may set our own Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Description (*)



This PR adds Cron Group generation action.
Fixed Issues (if relevant)
Contribution checklist (*)