Skip to content

252 fixed null pointer issue #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 28, 2020
Merged

252 fixed null pointer issue #257

merged 8 commits into from
May 28, 2020

Conversation

VitaliyBoyko
Copy link
Contributor

Description (*)

  • This PR fixes null pointer exception ('Update failed for "NewModuleFileGroup"')
  • Adjusted changelog
  • fixed module icons

Fixed Issues (if relevant)

  1. Update failed for "NewModuleFileGroup" #252: Update failed for "NewModuleFileGroup"

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 self-assigned this May 27, 2020
eduard13
eduard13 reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small adjustment

@VitaliyBoyko
Copy link
Contributor Author

@eduard13
Thank you!

@VitaliyBoyko VitaliyBoyko merged commit b1adf1f into 1.0.1-develop May 28, 2020
@VitaliyBoyko VitaliyBoyko deleted the 252-fixed-issue-with-new-module-group-prepare-release branch May 28, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

Labels
Easy Expert Partner: Atwix partners-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VitaliyBoyko @eduard13 @magento-engcom-team