Skip to content

Removed usage of the JavaScriptFileType constructor #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 14, 2020
Merged

Removed usage of the JavaScriptFileType constructor #285

merged 6 commits into from
Oct 14, 2020

Conversation

VitaliyBoyko
Copy link
Contributor

Description (*)
Removed usage of the JavaScriptFileType constructor according to the request:
image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 self-requested a review October 5, 2020 13:59
@eduard13 eduard13 self-assigned this Oct 5, 2020
eduard13
eduard13 approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@VitaliyBoyko VitaliyBoyko requested a review from eduard13 October 6, 2020 05:03
@okorshenko okorshenko requested a review from eduard13 October 14, 2020 14:37
@VitaliyBoyko VitaliyBoyko merged commit db3aa7f into 2.0.0-develop Oct 14, 2020
@VitaliyBoyko VitaliyBoyko deleted the fixed-usage-of-JavaScriptFileType branch October 14, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 Awaiting requested review from eduard13

1 more reviewer

@okorshenko okorshenko okorshenko approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@okorshenko okorshenko

@eduard13 eduard13

Labels
Partner: Atwix partners-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VitaliyBoyko @okorshenko @eduard13 @magento-engcom-team