Changed new controller dialog validator

[drpayyne]

Description

This PR adds validation through annotations to the new controller dialog and removes the unnecessary com.magento.idea.magento2plugin.actions.generation.dialog.validator.NewControllerValidator

Fixed Issues

1. Change validation for the new controller dialog window #297: Change validation for the new controller dialog window

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with integration/functional tests (if applicable)
• All automated tests passed successfully (all builds are green)

[VitaliyBoyko]

QA failed

Case:
controller should begin with the capital letter ⛔

wrong exception message

Same for action name.
Please check all the cases and messages.

[VitaliyBoyko]

Please consider checking all validation cases.

[drpayyne]

Hi @VitaliyBoyko, I've fixed the issues. Please review. Thanks!

[VitaliyBoyko]

QA failed ⛔
Fill out the Controller Name with the not valid symbols.

Wrong message

For the Action Name works well. ✅

[drpayyne]

@VitaliyBoyko, controller name already does a namespace check. Would it be better if we fix that instead of adding another rule to this field to limit it to alphanumeric?

[VitaliyBoyko]

@VitaliyBoyko, controller name already does a namespace check. Would it be better if we fix that instead of adding another rule to this field to limit it to alphanumeric?

Yes

[drpayyne]

Hi @VitaliyBoyko, I've remove the PhpNamespaceRule check and instead used AlphanumericRule check. The namespace rule actually only checks if the value is a PHP identifier and not a reserved keyword. This doesn't work for our use case.

[VitaliyBoyko]

⛔

Classes names can begin from a number.

[VitaliyBoyko]

Please check the case with a number at the beginning of a class name.

[drpayyne]

Hi @VitaliyBoyko, all these validations have confused me on valid PHP namespaces and PHP classes. Can you please check the below links and guide me on how to proceed?

• https://www.php.net/manual/en/language.namespaces.rationale.php#104196
• https://www.php.net/manual/en/language.oop5.basic.php (2nd paragraph)

Thanks.