Skip to content

Changed validator for NewGraphQlResolverDialog #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2020
Merged

Changed validator for NewGraphQlResolverDialog #327

merged 3 commits into from
Oct 22, 2020

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Oct 21, 2020 •
edited
Loading

Description

This PR changes the validator for NewGraphQlResolverDialog.

Fixed Issues

  1. Change validation for the new GraphQl resolver dialog window #300: Change validation for the new GraphQl resolver dialog window

Additional changes

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@coderimus coderimus self-assigned this Oct 22, 2020
@coderimus
Copy link
Contributor

Hello @drpayyne
Everything good. I reviewed the PR, and it is approved to be merged. But the latest merge to the 2.1.0-develop caused a conflict to your PR. Please, fix it, and we will merge.
Thank you,
Alex

coderimus
coderimus suggested changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@coderimus coderimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything good. Only conflicts should be resolved.

@drpayyne
Copy link
Contributor Author

Hi @coderimus, thanks for you review. I've fixed the conflicts. Please review again.

@drpayyne drpayyne requested a review from coderimus October 22, 2020 17:25
@coderimus coderimus merged commit f4491c5 into magento:2.1.0-develop Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@coderimus coderimus coderimus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@coderimus coderimus

Labels
partners-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drpayyne @coderimus @magento-engcom-team