Changed validator for NewCronjobDialog #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpayyne
commented
Oct 23, 2020
Comment on lines
-257
to
-281
| final String moduleName = dialog.getCronjobModule(); | ||
| final NamespaceBuilder namespaceBuilder = new NamespaceBuilder( | ||
| moduleName, | ||
| cronjobClassName, | ||
| cronjobDirectory | ||
| ); | ||
| final PhpClass cronjobClassFile = GetPhpClassByFQN.getInstance(project).execute( | ||
| namespaceBuilder.getClassFqn() | ||
| ); | ||
|
|
||
| if (cronjobClassFile != null) { | ||
| final String errorMessage = validatorBundle.message( | ||
| "validator.file.alreadyExists", | ||
| "Cronjob Class" | ||
| ); | ||
|
|
||
| JOptionPane.showMessageDialog( | ||
| null, | ||
| errorMessage, | ||
| errorTitle, | ||
| JOptionPane.ERROR_MESSAGE | ||
| ); | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
This is yet to be implemented. Similar to checking if PHP class exists already.
VitaliyBoyko
requested changes
Oct 23, 2020
...m/magento/idea/magento2plugin/actions/generation/dialog/validator/rule/CronScheduleRule.java
Show resolved
Hide resolved
...om/magento/idea/magento2plugin/actions/generation/dialog/validator/rule/BoxNotEmptyRule.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed validator for
com.magento.idea.magento2plugin.actions.generation.dialog.NewCronjobDialogFixed Issues
Additional Changes
BoxNotEmptyRuleto validate if an option from the dropdown is selected. This can be ported to validate module list dropdown and theme list dropdown as well, while implementing filtering. So we end up getting a validation of 'an option from the pre-populated list is selected' and a filtering the list with an editable field.Contribution checklist