Skip to content

Fixed observer name validator #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2020
Merged

Fixed observer name validator #428

merged 2 commits into from
Dec 18, 2020

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Dec 17, 2020 •
edited
Loading

Description

This PR fixes the observer validator as described in the issue

Fixed Issues

  1. Fixes Change the validation of the Name field in the New Observer dialog window #421: Change the validation of the Name field in the New Observer dialog window

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 self-assigned this Dec 17, 2020
@VitaliyBoyko
Copy link
Contributor

Would be good to have a backport to 3.0.3-develop

@drpayyne drpayyne mentioned this pull request Dec 18, 2020
Merged
4 tasks
@drpayyne
Copy link
Contributor Author

Would be good to have a backport to 3.0.3-develop

Done: #430

eduard13
eduard13 approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might conflict with #429 or vice versa.

@eduard13 eduard13 added the Easy label Dec 18, 2020
@VitaliyBoyko VitaliyBoyko merged commit d8cea9c into magento:3.1.0-develop Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

Labels
Easy Partner: EY partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the validation of the Name field in the New Observer dialog window
4 participants
@drpayyne @VitaliyBoyko @eduard13 @magento-engcom-team