Skip to content

Create new action controller generation #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 15, 2021
Merged

Create new action controller generation #481

merged 8 commits into from
Feb 15, 2021

Conversation

anzin
Copy link
Contributor

@anzin anzin commented Feb 10, 2021

Description (*)
I've implemented:

  1. Created the generator for the NewAction controller.
  2. Created test for the NewAction controller.
  3. Fixed Save Controller ADMIN_RESOURCE, Fixed Save Controller Test.

image
image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@VitaliyBoyko VitaliyBoyko self-requested a review February 10, 2021 14:19
@VitaliyBoyko VitaliyBoyko self-assigned this Feb 10, 2021
@VitaliyBoyko
Copy link
Contributor

Please fix conflicts

@anzin
Merge branch 'mainline-entity-manager' of github.com:magento/magento2…
5d35064 
…-phpstorm-plugin into create-new-action-controller-generation
@anzin
Copy link
Contributor Author

anzin commented Feb 10, 2021

@VitaliyBoyko I've fixed the conflicts

VitaliyBoyko
VitaliyBoyko requested changes Feb 12, 2021
View reviewed changes
resources/fileTemplates/internal/Magento Entity New Action Controller Class.php.ft Outdated
{
/** @var ${FORWARD} $resultForward */
$resultForward = $this->resultFactory->create(${RESULT_FACTORY}::TYPE_FORWARD);
$resultForward->forward('edit');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not get why do we need forward 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We expect something like this https://github.com/magento/inventory/blob/1.2-develop/InventoryAdminUi/Controller/Adminhtml/Stock/NewAction.php

Copy link
Contributor Author

@anzin anzin Feb 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VitaliyBoyko I've changed generated file by your recommendation.

@VitaliyBoyko VitaliyBoyko merged commit 3ce4d07 into magento:mainline-entity-manager Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBoyko VitaliyBoyko VitaliyBoyko approved these changes

Assignees

@VitaliyBoyko VitaliyBoyko

Labels
Award: test coverage Medium Partner: Atwix partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anzin @VitaliyBoyko @magento-engcom-team @bohdan-harniuk