Skip to content

Conversation

bohdan-harniuk
Copy link
Collaborator

Description (*)
Improved UX by adding autocompletion for entity name dependent fields.

ezgif com-gif-maker

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please review the below question?

Comment on lines +1394 to +1396
formLabel.setText(entityNameLabel.concat(" Form"));
formName.setText(entityName.concat("_form"));
gridName.setText(entityName.concat("_listing"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently checking this, and my question is: What if you don't check the Create Admin Ui Components checkbox? Per my understanding, we should completely hide the Admin Ui Components tab if we have it unchecked and no other action should be done in scope of Ui Components tab.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't check the Create Admin Ui Components checkbox you won't get generated any files related to UI components.

We cannot depend on it during inputs autocompletion. What if we will fill all inputs on the first tab and only then check the Create Admin Ui Components checkbox? That is why better to leave this in this way - it is more clear for the user.

What about hiding the Admin Ui Components tab, it is a good idea. I'll implement it. Thank you!

After it will be implemented, I'll leave a comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiding that tab would be more logical, and it won't confuse the end-user, since he unchecked the checkbox, but still sees the Tab.

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants