-
Notifications
You must be signed in to change notification settings - Fork 102
Improved UX by adding autocompletion for entity name dependent fields #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved UX by adding autocompletion for entity name dependent fields #483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please review the below question?
formLabel.setText(entityNameLabel.concat(" Form")); | ||
formName.setText(entityName.concat("_form")); | ||
gridName.setText(entityName.concat("_listing")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm currently checking this, and my question is: What if you don't check the Create Admin Ui Components
checkbox? Per my understanding, we should completely hide the Admin Ui Components
tab if we have it unchecked and no other action should be done in scope of Ui Components tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't check the Create Admin Ui Components checkbox you won't get generated any files related to UI components.
We cannot depend on it during inputs autocompletion. What if we will fill all inputs on the first tab and only then check the Create Admin Ui Components checkbox? That is why better to leave this in this way - it is more clear for the user.
What about hiding the Admin Ui Components tab, it is a good idea. I'll implement it. Thank you!
After it will be implemented, I'll leave a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiding that tab would be more logical, and it won't confuse the end-user, since he unchecked the checkbox, but still sees the Tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description (*)
Improved UX by adding autocompletion for entity name dependent fields.
Contribution checklist (*)