Added Generator Delete Entity By Id #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
resources/META-INF/plugin.xml
Outdated
| @@ -238,6 +238,7 @@ | |||
| <internalFileTemplate name="Magento PHP Form Generic Button Block Class"/> | |||
| <internalFileTemplate name="Magento Entity New Action Controller Class"/> | |||
| <internalFileTemplate name="Magento New Entity Layout XML"/> | |||
| <internalFileTemplate name="Magento Delete Entity By Id Command Model"/> | |||
There was a problem hiding this comment.
I wonder why we need the word Model here. It's just a command, isn’t it?
There was a problem hiding this comment.
@eduard13 @coderimus what do you think guys?
There was a problem hiding this comment.
💯 agree, Model word is extra. But for me this "Command" is a bit confusing. For me it looks like a Service Contract, that handles the Entity removal, which should have an API interface and a Service that implements it.
What do you think?
There was a problem hiding this comment.
@VitaliyBoyko agree that the Model is an extra word.
4 tasks
VitaliyBoyko
requested changes
Feb 18, 2021
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
|
Hello, @VitaliyBoyko I've fixed the code by recommendation. Thank you |
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
I've implemented:
Contribution checklist (*)