Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#44 :- Templates. Fill information about Plugin Templates #50

Conversation

konarshankar07
Copy link
Contributor

@konarshankar07 konarshankar07 commented Mar 24, 2020

Fixed #44
This PR will add the plugin description in the plugin code templates

Expected Result

After Plugin
image
Before Plugin
image
Around Plugin
image

@VitaliyBoyko
Copy link
Contributor

VitaliyBoyko commented Mar 24, 2020

Hi @konarshankar07
Looks great! This is really what I supposed to see.

I see the little issue, variables from template don't match variables in the description.
image
For example, we have no TYPE_NAME variable within the template at all.

Could you please review actual variables and describe them. I believe, they are quite self-explanatory, so It should not be a big problem.
Thank you!

@VitaliyBoyko VitaliyBoyko self-requested a review March 24, 2020 06:50
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment.

@konarshankar07
Copy link
Contributor Author

@VitaliyBoyko .. Please review again
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants