539 add apply to property

[ProkopovVitaliy]

Description (*)

Added possibility set apply_to property for product eav attribute.

There are two variants how to use this property in data patch generation:

1. Apply attribute for all available product types in the system:
   
   If Apply to all products types selected no specific product type will be specified for the attribute.

2. Specify product types:

Unselect Apply to all products types, and it will be possible to specify product types:

After that will be generated data patch with specified product types:

Fixed Issues (if relevant)

1. Fixes Eav attribute generation for specified products types. #539

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with integration/functional tests (if applicable)
• All automated tests passed successfully (all builds are green)

[eduard13]

Hi @ProkopovVitaliy, thank you for the provided changes. But I guess providing a multiple select with available product types, would be much more user friendly. Additionally, we'll avoid entering some typos within that field.

Please let me know your thoughts.

Thank you.

[ProkopovVitaliy]

Hi @ProkopovVitaliy, thank you for the provided changes. But I guess providing a multiple select with available product types, would be much more user friendly. Additionally, we'll avoid entering some typos within that field.

Please let me know your thoughts.

Thank you.

Hi @eduard13 Yes you are right, this is more user friendly. But if developer have custom product type in their store, for example sellable, we cannot predict such options and it can be some restriction for interact with our dialog window.So that why i added "help text block" which contain default types:

Enter comma separated product types for which attribute will available, for example: simple,configurable,bundle,virtual,downloadable,category. Or leave this property blank if you want apply attribute for all product types.

What about your opinion ?

[DmitryFurs]

@ProkopovVitaliy @eduard13 Magento provides product_types.xml file that describes the product types. Is it possible to implement support for this file for the apply_to option? When typing manually, there is a chance of making a typo. There may also be third-party product types. If there was multiselect option, it would be very convenient. Thanks!

https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Downloadable/etc/product_types.xml#L9
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/ConfigurableProduct/etc/product_types.xml#L9

[VitaliyBoyko]

@ProkopovVitaliy
So we can add a file indexer for product_types.xml, and build options accordingly.

[ProkopovVitaliy]

@eduard13 I finalized this functionality. Could you please review it?

Main points:

• Added indexer for product_types.xml
• Added multi-select for apply_to property that based on parsed result from product_types.xml files.

Overview:

1. Create attribute for all product types:
   
   
   There are no changes.

2. Create attribute for specified product types:
   
   
   As we can see here added new multi-select field with product types.

3. And the new one. When we decide to create new product type we will see him in the multi-select:
   Create new product type:
   

Run reindex for plugin:

Open window for generation and try generate attribute for new created product type:

[eduard13]

@ProkopovVitaliy, just want to bring your attention, that breaking a multiple arguments to a new line, should move all the arguments to a new empty line, like following.

Suggested change

	mappedAttributes.put(EavAttribute.APPLY_TO.getAttribute(),
	wrapStringValueForTemplate(eavEntityData.getApplyTo()));
	mappedAttributes.put(
	EavAttribute.APPLY_TO.getAttribute(),
	wrapStringValueForTemplate(eavEntityData.getApplyTo())
	);

[ProkopovVitaliy]

@eduard13 Thanks for recommendation, really it's looks better in your variant. I will take this into account.

Thanks!

[eduard13]

No action is needed here, just wanted to add a remark, it also applies to PHP code.

[eduard13]

Thank you for the feature 👍.