Added possibility to set options #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
…options # Conflicts: # resources/fileTemplates/internal/Magento Eav Attribute Data Patch Class.php.ft # src/com/magento/idea/magento2plugin/actions/generation/dialog/NewEavAttributeDialog.form # src/com/magento/idea/magento2plugin/actions/generation/dialog/NewEavAttributeDialog.java # src/com/magento/idea/magento2plugin/actions/generation/generator/util/eav/ProductAttributeMapper.java # src/com/magento/idea/magento2plugin/magento/packages/eav/EavAttribute.java # tests/com/magento/idea/magento2plugin/actions/generation/generator/EavAttributeSetupPatchGeneratorTest.java
VitaliyBoyko
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added possibility set options. We can add options only if input type selected
multi-selectorselectand didn’t set source model.For example in this case we can’t see options pane:
If we set source model as
Without Source Modelwe can see options panel here:Now try to set options without sort orders:
After generation we will see next data patch file:
After
bin/magento setup:upgradecommand execution let's check the attribute in admin panel:As we can see, product options works as we expected. On the product edit page it works as expected also:
Let's do the same but with sort ordered option:
Generated file:
Attribute in admin panel:
Fixed Issues (if relevant)
Questions or comments
Contribution checklist (*)