Skip to content

Multiple improvements to EAV generators #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eduard13
Copy link
Contributor

Description (*)
This PR aims to bring multiple improvements to EAV generators:

  • Entity Type should be imported
  • Removed not needed constructor description
  • Reordered the DataPatch methods
  • Updated tests

Fixed Issues (if relevant)
N/A

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

*
* @return $this
*/
public function apply()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope :)

@@ -6,8 +6,8 @@
package com.magento.idea.magento2plugin.magento.packages.eav;

public enum EavEntity {
PRODUCT("\\Magento\\Catalog\\Model\\Product"),
CATEGORY("\\Magento\\Catalog\\Model\\Category");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@VitaliyBoyko VitaliyBoyko merged commit 4078a6b into magento:mainline-eav-attr-code-genearators Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants