Skip to content

[UCT] Developed Existence index #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

bohdan-harniuk
Copy link
Collaborator

Description (*)

What was done:

  • developed new index for storing existence state for classes/interfaces, public/protected constants && fields && methods
  • refactored deprecated index
  • enhanced reindexing process
  • reindexed Magento from V.2.3.0 till V.2.4.3 (existence index)
  • enhanced index processors

Fixed Issues (if relevant)

  1. Fixes [UCT] Add index for storing Magento 2 (from v.2.3.0) codebase state of existence #702

Steps to test reindex process (existence index):

  1. Download sandbox data for testing (attached below 👇)
  2. Extract it to the IntelliJ Magento 2 PHPStorm Plugin Sandbox Project into the <project-root>/app/code
  3. Reindex one by one folders from V1 to V5 (via context menu action: Reindex the UCT versioned indexes)
  4. In the reindex dialog choose target version (V1 - 2.3.0, V2 - 2.3.1, V3 - 2.3.2, V4 - 2.3.2-p2, V5 - 2.3.3)
  5. In the reindex dialog choose target index (Existence)
  6. Click the "Reindex" button

Сheck compliance with the expected data:

To get readable data from the stored index debug: com.magento.idea.magento2uct.versioning.processors.ExistenceIndexProcessor#save and underlying saving process.

Expected data:

FILES V1 V2 V3 V4 V5
A
B
C
D
E
F
G
H
A.property
A.method
B.CON
C.CON
D.method
E.property
E.property2
F.property1
F.property2
F.method1
F.method2
Summary: 6 added 5 added, 2 deleted 4 added, 3 deleted 1 deleted 5 added, 1 deleted

Sandbox data for testing: Sandbox.zip

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Collaborator

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bohdan-harniuk
Thank you for your contribution here.
Great job

@eduard13 eduard13 merged commit a1769b2 into magento:4.2.0-develop Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UCT] Add index for storing Magento 2 (from v.2.3.0) codebase state of existence
3 participants