Skip to content

Add license select to the new module #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vasilii-b
Copy link

Description (*)

This PR makes it possible to specify the module's license(s) at the "New Magento 2 Module" dialog.

Add license for new magento 2 module

It is possible to

  1. Select multiple licenses
  2. Add custom license name
  3. Mix provided licenses with custom one

The "Custom License Name" input is available only when the "Custom License" is selected.

custom license visibility

Fixed Issues (if relevant)

  1. Action/Code Generation. Add license select to the new module #55: Action/Code Generation. Add license select to the new module

Questions or comments

I wonder whenever the changes/approach added in file idea/magento2plugin/actions/generation/generator/ModuleComposerJsonGenerator.java is fine or not.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@MellenIO
Copy link

MellenIO commented Apr 1, 2020

Although I'm not part of the team here, I read your PR and believe some things could be improved about it - would I be alright to leave some notes later today? :)

@vasilii-b
Copy link
Author

Hi @MellenIO,
I believe yes, you can write your suggestions.
You can also open a new issue with your suggestions anytime.
Cheers!

@VitaliyBoyko
Copy link
Contributor

Hi, @MellenIO,
This is an opensource project, anyone can be part of the team. You as well ;)

@VitaliyBoyko VitaliyBoyko merged commit f723a9a into magento:1.0.0-develop Apr 2, 2020
@vasilii-b vasilii-b deleted the new-module-creation-add-license branch April 2, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants