Skip to content

📦 #58 Block Generation #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 4, 2020
Merged

📦 #58 Block Generation #92

merged 5 commits into from
Apr 4, 2020

Conversation

roma-glushko
Copy link
Member

Description (*)

This PR provides an additional action that helps to generate new block components.

Fixed Issues (if relevant)

  1. Action/Code Generation. Block generation #58: Action/Code Generation. Block generation

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@roma-glushko roma-glushko linked an issue Apr 3, 2020 that may be closed by this pull request
Action/Code Generation. Block generation #58
Closed
@roma-glushko roma-glushko self-assigned this Apr 3, 2020
@m2-community-project
Copy link

@roma-glushko unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@Vinai
Copy link

Vinai commented Apr 3, 2020

How about adding a little note to the New Block dialogue:
"Please consider creating a view model instead of a block if possible for your use case".

@VitaliyBoyko
Copy link
Contributor

Hi @Vinai
Makes sense.

Merge branch '1.0.0-develop' of https://github.com/magento/magento2-p…
058a562 
…hpstorm-plugin into 58-block-generation

� Conflicts:
�	src/com/magento/idea/magento2plugin/magento/packages/Package.java
@Vinai
Copy link

Vinai commented Apr 3, 2020

Love your work here btw 👍

@VitaliyBoyko
Copy link
Contributor

Thanks!

@VitaliyBoyko VitaliyBoyko self-assigned this Apr 3, 2020
@VitaliyBoyko VitaliyBoyko merged commit e80377c into magento:1.0.0-develop Apr 4, 2020
@vasilii-b vasilii-b mentioned this pull request Apr 6, 2020
Merged
2 tasks
bohdan-harniuk pushed a commit that referenced this pull request Apr 7, 2020
[xmlCompletion] #92 - Fixed wrong completion applying by file name
7085982
bohdan-harniuk pushed a commit that referenced this pull request Apr 7, 2020
[xmlCompletionTesting] #92 - Added testing for source_model Xml attri…
fb1e405 
…bute and tag
bohdan-harniuk pushed a commit that referenced this pull request Apr 7, 2020
[xmlCompletionTesting] #92 - Added testing for source_model Xml attri…
f07c8fd 
…bute and tag
bohdan-harniuk pushed a commit that referenced this pull request Apr 7, 2020
[xmlCompletionTesting] #92 - Added testing for source_model Xml attri…
5a921fb 
…bute and tag
@VitaliyBoyko VitaliyBoyko mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBoyko VitaliyBoyko VitaliyBoyko approved these changes

Assignees

@VitaliyBoyko VitaliyBoyko

Labels
action code generation Event: Global-Contribution-Day Medium Partner: Atwix partners-contribution release-1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Action/Code Generation. Block generation
4 participants
@roma-glushko @Vinai @VitaliyBoyko @magento-engcom-team