965: Added a new context dependent Action for the acl.xml file generation #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doninAtwix
changed the title
bohdan-harniuk
added
Partner: Atwix
partners-contribution
and removed
Progress: review
labels
src/com/magento/idea/magento2plugin/actions/context/xml/NewAclXmlAction.java
Outdated
Show resolved
Hide resolved
bohdan-harniuk
requested changes
Feb 9, 2022
There was a problem hiding this comment.
Hello, @doninAtwix!
Please, check my comment.
Also, do not forget to update your branch from the mainline.
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
# Conflicts: # resources/META-INF/plugin.xml
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
eduard13
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
965: Added a new context dependent Action for the acl.xml file generation
Fixed Issues (if relevant)
Questions or comments
Contribution checklist (*)