Category\Collection::joinUrlRewrite should use the store set on the collection

[alepane21]

The problem is that Magento\Catalog\Model\ResourceModel\Category\Collection::joinUrlRewrite always use the store id from the store manager. I think that it should instead use the storeId set on the actual collection.

Description

Now joinUrlRewrite uses directly the storeManager, but if a store is set directly on the collection, it should use the store set, and not the default passed by the store manager.
The method getStoreId(), if not set, already goes on fallback to the store manager and get the default, so it should be safe to directly use getStoreId().

Fixed Issues (if relevant)

1. Category\Collection::joinUrlRewrite should use the store set on the collection #13704: Category\Collection::joinUrlRewrite should use the store set on the collection

Manual testing scenarios

I already provided an automated unit test. There is an code example in the related issue #13704.
It's my first automated test here, so I hope it's ok :)

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[dmanners]

Hi @alepane21 thanks for this pull request. I will have a look at processing it now.

[magento-engcom-team]

@alepane21 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[dmanners]

Hi @alepane21 thank you for this PR. Would you be able to also add in an integration test to cover this change also?

For an example I would suggest looking at app/code/Magento/Catalog/Model/ResourceModel/Category/Collection.php::testJoinTable

[alepane21]

Well, if you need it I think I can do it. But you'll have to wait this weekend.

[alepane21]

Hi @dmanners, done. There is an error in codacy but I think it's unrelated.

[dmanners]

Thank you @alepane21 for your hard work. I will take another look over this.

[magento-engcom-team]

Hi @dmanners, thank you for the review.
MAGETWO-88107 has been created to process this Pull Request