Skip to content

Conversation

ghost
Copy link

@ghost ghost commented May 4, 2019

Description (*)

Fixed Issues (if relevant)

  1. In customer account create page word not readable, should use '-' after break to new line In mobile view #22647: In customer account create page word not readable, should use '-' after break to new line In mobile view

Manual testing scenarios (*)

  1. Open customer account create page in mobile view

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @ManishGangola-Webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 4, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Copy link
Contributor

@Karlasa Karlasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrGangola-Webkul
Thanks for your PR
Under issue @cedarvinda mentioned that he will work on this issue and also made PR.
Because of that will close this PR and go forward with his solution.

Cheers,
Karla

@Karlasa Karlasa closed this May 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @MrGangola-Webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants