Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behaviour of getStockItem() and getStockData() #37937

Closed
1 of 5 tasks
GamesmenJordan opened this issue Aug 30, 2023 · 7 comments
Closed
1 of 5 tasks

Inconsistent behaviour of getStockItem() and getStockData() #37937

GamesmenJordan opened this issue Aug 30, 2023 · 7 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.5 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@GamesmenJordan
Copy link

Preconditions and environment

Magento version 2.4.5 (tested)

Create simple observer for event catalog_product_save_before with the following execute method:

public function execute(\Magento\Framework\Event\Observer $observer) {
        $product = $observer->getProduct();
        $stockItem = $product->getStockItem();
        $stockData = $product->getStockData();
        return; //set breakpoint here
}

Steps to reproduce

  1. Save a product in the Admin portal
  2. Observe that $stockData will be populated with the stock item object, but $stockItem will be null
  3. Save a product via the REST API
  4. Observe that $stockItem will be populated with the stock item object, but now $stockData will be null

Expected result

Both getStockData() or getStockItem() should behave consistently regardless of how the product is saved, likely both returning the data or one function becoming an alias for the other.

Actual result

  1. getStockData() only returns the stock item object if the product was saved via the admin portal UI, otherwise returning null.
  2. getStockItem() only returns the stock item object if the product was saved via the REST API, otherwise returning null.

Both functions return the same stock item object in their respective scenarios.

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Aug 30, 2023

Hi @GamesmenJordan. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Bravo engcom-Bravo added Reported on 2.4.5 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it labels Aug 30, 2023
@Usik2203
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @Usik2203. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Hotel engcom-Hotel self-assigned this Sep 1, 2023
@m2-assistant
Copy link

m2-assistant bot commented Sep 1, 2023

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel
Copy link
Contributor

Hello @GamesmenJordan,

Thanks for the report and collaboration!

We have tried to reproduce the issue in Magento 2.4-develop branch but it seems the issue is not reproducible for us. We have made an Observer in order to reproduce the issue.

Please find below the same as a reference:

Magz.zip

We request you to please review the steps to reproduce and let us know if anything is missed.

Thanks

@engcom-Hotel engcom-Hotel added Issue: needs update Additional information is require, waiting for response and removed Issue: ready for confirmation labels Sep 1, 2023
GamesmenJordan added a commit to GamesmenJordan/magento2 that referenced this issue Sep 8, 2023
When async grid update is enabled the instance of IdListBuilder gets reused across multiple grid update tasks. This causes the associated join to the archived grid tables to accumulate for each and results in joining unrelated archived grid tables.

In certain circumstances this results in invoices, shipments and creditmemos incorrectly being excluded from the list of IDs not present in the grid.
@engcom-Hotel
Copy link
Contributor

Dear @GamesmenJordan,

We have noticed that this issue has not been updated for a long time. Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.5 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

No branches or pull requests

4 participants