Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6916 Fix notice during Update Bundle Product without changes #12734

Merged
merged 1 commit into from
Dec 28, 2017

Conversation

dzianis-yurevich
Copy link

Description

If we need to update (not new) bundle product and edit any Bundle Items then the saving process works fine.
If we assign a new category and image to the product then the saving process doesn't work.

Fixed Issues

  1. Update Bundle Product without changes in bundle items  #6916: Update Bundle Product without changes in bundle items

Manual testing scenarios

  1. Edit sample product "Sprite Yoga Companion Kit"
  2. by default this product has 4 options in bundle items. You need to add more so in total you have at least 21 options. And now we got Bundle Items pager.
  3. Save product with all options and reload page.
  4. Click save without any changes. you should see error.
  5. If you move to the second page of bundle items and click save everything works correct.
    Looks like system think we trying to remove invisible items.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 15, 2017

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added bugfix Component: Catalog mageconf Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 15, 2017
@ishakhsuvarov
Copy link
Contributor

Hi @dzianis-yurevich
Please sign the CLA in the comment above so that we could proceed with the review and merge of your PR.
Thank you.

@dzianis-yurevich
Copy link
Author

@ishakhsuvarov
CLA has been signed. Thank you!

@ishakhsuvarov
Copy link
Contributor

@dzianis-yurevich Thank you

@ishakhsuvarov
Copy link
Contributor

@dzianis-yurevich Do you think you could update


to support this case?

@okorshenko okorshenko self-assigned this Dec 26, 2017
@okorshenko okorshenko added this to the December 2017 milestone Dec 26, 2017
@magento-team magento-team merged commit e6a7a4e into magento:2.2-develop Dec 28, 2017
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants