Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves PHPdoc issue in ticket #13992 #14303

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Resolves PHPdoc issue in ticket #13992 #14303

merged 1 commit into from
Mar 26, 2018

Conversation

julian-van-drielen
Copy link

@julian-van-drielen julian-van-drielen commented Mar 24, 2018 •
edited
Loading

Description

Incorrect PHPdoc causes warnings in IDE. I just changed the return type to the type it actually returns in the PHPdoc.

Fixed Issues (if relevant)

  1. Incorrect phpdoc should be Shipment\Item not Invoice\Item #13992: Incorrect phpdoc should be Shipment\Item not Invoice\Item

Manual testing scenarios

  1. This is not necessary, this just resolves warnings in the IDE.

Contribution checklist

  • [✓] Pull request has a meaningful description of its purpose
  • [✓] All commits are accompanied by meaningful commit messages
  • [✓] All new or changed code is covered with unit/integration tests (if applicable)
  • [] All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 24, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@larsroettig larsroettig self-requested a review March 24, 2018 10:52
@larsroettig
Copy link
Member

@cream-julian can sign the CLA, please thank you

@julian-van-drielen
Copy link
Author

@larsroettig Signed the CLA. Check not updated yet?

@osrecio osrecio self-assigned this Mar 24, 2018
@osrecio
Copy link
Member

osrecio commented Mar 24, 2018

@cream-julian Can you retry to signn CLA?

@julian-van-drielen
Copy link
Author

Seems like its signed now!

@osrecio
Copy link
Member

osrecio commented Mar 24, 2018

Thanks @cream-julian I will process today your PR. :)

@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 24, 2018
@osrecio osrecio added the Event: distributed-cd Distributed Contribution Day label Mar 24, 2018
@magento-engcom-team
Copy link
Contributor

Hi @larsroettig, thank you for the review.
ENGCOM-1058 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Mar 26, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 564ab99 into magento:2.2-develop Mar 26, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 26, 2018
ENGCOM-1058: Resolves PHPdoc issue in ticket #13992 #14303
1db9a0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsroettig larsroettig larsroettig approved these changes

Assignees

@osrecio osrecio

@larsroettig larsroettig

Labels
Community Insider: Cream community-insider-contribution Event: distributed-cd Distributed Contribution Day Progress: accept Release Line: 2.2
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
7 participants
@julian-van-drielen @magento-cicd2 @larsroettig @osrecio @magento-engcom-team @dverkade @kevincream