Fixed review list ajax if product not exist redirect to 404 page #13102

[ananth-iyer]

Description

Issue was review list ajax call giving php error log or error number if invalid product id. It should be 404 page.

Fixed Issues (if relevant)

1. review/product/listAjax/id/{{non existent id}/ #13102, Page was not redirect to 404 page.

Manual testing scenarios

1. Use invalid product id in review list ajax
2. For example: <Magento store url>/review/product/listAjax/id/{{non existent id}/

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[larsroettig]

Hi @Ananth747, can you sign pls our contributor License Agreement.
I start now with review and testing.

best regards,

Lars

[larsroettig]

It is unnecessary else statement you can remove this.

 /**
     * Show list of product's reviews
     *
     * @return \Magento\Framework\App\ResponseInterface|\Magento\Framework\Controller\ResultInterface
     */
    public function execute()
    {
        if (!$this->initProduct()) {
            /** @var \Magento\Framework\Controller\Result\Forward $resultForward */
            $resultForward = $this->resultFactory->create(ResultFactory::TYPE_FORWARD);
            return $resultForward->forward('noroute');
        }

        return $this->resultFactory->create(ResultFactory::TYPE_LAYOUT);
    }

[ananth-iyer]

@larsroettig @magento-cicd2 I've signed CLA when it will be accepted?

[sidolov]

Hi @Ananth747 , looks like your commits were pushed with the different email than on GitHub profile, please, add email from commits to your account and issue with CLA will be fixed.

[ananth-iyer]

@magento-cicd2 @sidolov @larsroettig
I've added the email that was used for commit. Now CLA check is passed.
Sorry for the misunderstanding.

[magento-engcom-team]

Hi @Ananth747. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.