-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link logo in web setup wizard to back-end base URL #17543
Link logo in web setup wizard to back-end base URL #17543
Conversation
Hi @arnoudhgz. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@@ -20,13 +27,13 @@ | |||
ng-show="<?= implode( '&&', $expressions) ?>" | |||
> | |||
<nav class="admin__menu" ng-controller="mainController"> | |||
<span | |||
class="logo logo-static" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @arnoudhgz, thanks for your contribution!
When you remove the CSSclass logo-static
from the template, it should be possible to remove its declaration in the LESS file. Please can you look into this?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzeis thank you for the feedback, this was indeed possible.
It was also set in the setup/pub/styles/setup.css
file (which was actually loaded on the page).
I removed it from both locations.
When you get to the web setup wizard from the Magento back-end it was not possible to get back to the back-end from this page. This commit makes the logo clickable and when you click it you will return the Magento back-end.
Hi @arnoudhgz. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
When you get to the web setup wizard from the Magento back-end it was not possible to get back to the back-end from this page.
This commit makes the logo clickable and when you click it you will return the Magento back-end.
Fixed Issues (if relevant)
Sidebar shortcut to admin dashboard (Magento logo on top left) has no link in web setup wizard
Manual testing scenarios
Contribution checklist