Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link logo in web setup wizard to back-end base URL #17543

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Link logo in web setup wizard to back-end base URL #17543

merged 1 commit into from
Aug 14, 2018

Conversation

arnoudhgz
Copy link
Contributor

Description

When you get to the web setup wizard from the Magento back-end it was not possible to get back to the back-end from this page.

This commit makes the logo clickable and when you click it you will return the Magento back-end.

Fixed Issues (if relevant)

  1. Sidebar shortcut to admin dashboard (Magento logo on top left) has no link in web setup wizard #13948:
    Sidebar shortcut to admin dashboard (Magento logo on top left) has no link in web setup wizard
  2. ...

Manual testing scenarios

  1. Admin dashboard > System > Web Setup Wizard
  2. Click Magento logo on top left
  3. You get back to admin dashboard

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Component: Setup Release Line: 2.2 labels Aug 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mzeis mzeis self-assigned this Aug 12, 2018
@@ -20,13 +27,13 @@
ng-show="<?= implode( '&&', $expressions) ?>"
>
<nav class="admin__menu" ng-controller="mainController">
<span
class="logo logo-static"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arnoudhgz, thanks for your contribution!
When you remove the CSSclass logo-static from the template, it should be possible to remove its declaration in the LESS file. Please can you look into this?

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzeis thank you for the feedback, this was indeed possible.

It was also set in the setup/pub/styles/setup.css file (which was actually loaded on the page).

I removed it from both locations.

image

When you get to the web setup wizard from the Magento back-end it was
not possible to get back to the back-end from this page.

This commit makes the logo clickable and when you click it you will
return the Magento back-end.
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Component: Setup Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants