-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proxy generation return type #17552
Fix proxy generation return type #17552
Conversation
Hi @adrian-martinez-interactiv4. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
/** | ||
* @var array | ||
*/ | ||
protected $config = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it private, like any new property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to private
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, it is a test sample file, it is not used anywhere and changing this has no impact on unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I understand, still conventions should be obeyd ;)
78e9d52
to
70d8491
Compare
Hi @orlangur, thank you for the review. |
Hi @adrian-martinez-interactiv4. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This PR attempts to fix Proxy generation when return type is defined in class.
Description
Code generator for Proxy is missing returnType in the method info definition. Another neighbour generator classes already have this defined, but it seems it was forgotten here.
Fixed Issues (if relevant)
I've been looking through the issues but it seems nobody has reported this bug.
Manual testing scenarios
Actual output
Expected output
Contribution checklist