-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: Add unit test for PopularSearchTerms model #17739
Merged
magento-engcom-team
merged 1 commit into
magento:2.2-develop
from
dmytro-ch:2.2-unit-test-popular-search-terms
Sep 4, 2018
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
95 changes: 95 additions & 0 deletions
95
app/code/Magento/Search/Test/Unit/Model/PopularSearchTermsTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
<?php | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
declare(strict_types=1); | ||
|
||
namespace Magento\Search\Test\Unit\Model; | ||
|
||
use Magento\Framework\App\Config\ScopeConfigInterface; | ||
use Magento\Search\Model\PopularSearchTerms; | ||
use Magento\Search\Model\ResourceModel\Query\Collection; | ||
use Magento\Store\Model\ScopeInterface; | ||
|
||
/** | ||
* @covers \Magento\Search\Model\PopularSearchTerms | ||
*/ | ||
class PopularSearchTermsTest extends \PHPUnit\Framework\TestCase | ||
{ | ||
/** | ||
* Testable Object | ||
* | ||
* @var PopularSearchTerms | ||
*/ | ||
private $popularSearchTerms; | ||
|
||
/** | ||
* @var ScopeConfigInterface|\PHPUnit_Framework_MockObject_MockObject | ||
*/ | ||
private $scopeConfigMock; | ||
|
||
/** | ||
* @var Collection|\PHPUnit_Framework_MockObject_MockObject | ||
*/ | ||
private $queryCollectionMock; | ||
|
||
/** | ||
* Set Up | ||
* | ||
* @return void | ||
*/ | ||
protected function setUp() | ||
{ | ||
$this->scopeConfigMock = $this->createMock(ScopeConfigInterface::class); | ||
$this->queryCollectionMock = $this->createMock(Collection::class); | ||
$this->popularSearchTerms = new PopularSearchTerms($this->scopeConfigMock, $this->queryCollectionMock); | ||
} | ||
|
||
/** | ||
* Test isCacheableDataProvider method | ||
* | ||
* @dataProvider isCacheableDataProvider | ||
* | ||
* @param string $term | ||
* @param array $terms | ||
* @param $expected $terms | ||
* | ||
* @return void | ||
*/ | ||
public function testIsCacheable($term, $terms, $expected) | ||
{ | ||
$storeId = 7; | ||
$pageSize = 25; | ||
|
||
$this->scopeConfigMock->expects($this->once())->method('getValue') | ||
->with( | ||
PopularSearchTerms::XML_PATH_MAX_COUNT_CACHEABLE_SEARCH_TERMS, | ||
ScopeInterface::SCOPE_STORE, | ||
$storeId | ||
)->willReturn($pageSize); | ||
$this->queryCollectionMock->expects($this->once())->method('setPopularQueryFilter')->with($storeId) | ||
->willReturnSelf(); | ||
$this->queryCollectionMock->expects($this->once())->method('setPageSize')->with($pageSize) | ||
->willReturnSelf(); | ||
$this->queryCollectionMock->expects($this->once())->method('load')->willReturnSelf(); | ||
$this->queryCollectionMock->expects($this->once())->method('getColumnValues')->with('query_text') | ||
->willReturn($terms); | ||
|
||
$actual = $this->popularSearchTerms->isCacheable($term, $storeId); | ||
self::assertEquals($expected, $actual); | ||
} | ||
|
||
/** | ||
* @return array | ||
*/ | ||
public function isCacheableDataProvider() | ||
{ | ||
return [ | ||
['test01', [], false], | ||
['test02', ['test01', 'test02'], true], | ||
['test03', ['test01', 'test02'], false], | ||
['test04', ['test04'], true], | ||
]; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a recommendation for the future. If you are not going to reuse properties in different methods, it's a good idea to use local method variables instead of class properties.